Skip to content

Conversation

Spartan322
Copy link
Contributor

As was fixed with godotengine/godot#91208

@Spartan322 Spartan322 requested a review from a team as a code owner August 25, 2024 07:57
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't have GCC 14 to test, but the changes match Godot and pass tests, so seems fine to me.

@dsnopek dsnopek added bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.1 cherrypick:4.2 cherrypick:4.3 labels Aug 26, 2024
@dsnopek dsnopek merged commit aac0164 into godotengine:master Aug 26, 2024
12 checks passed
@Spartan322 Spartan322 deleted the gcc-14-Wtemplate-id-cdtor-warning branch August 27, 2024 04:02
@dsnopek
Copy link
Collaborator

dsnopek commented Sep 3, 2024

Cherry-picked for 4.3 in PR #1569

@dsnopek
Copy link
Collaborator

dsnopek commented Sep 3, 2024

Cherry-picked for 4.2 in PR #1570

@dsnopek
Copy link
Collaborator

dsnopek commented Sep 4, 2024

Cherry-picked for 4.1 in PR #1572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants